zabpehely
/
wireguard-tools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

curve25519-fiat32: uninline certain functions 

While this has a negative performance impact on x86_64, it has a
positive performance impact on smaller machines, which is where we're
actually using this code. For example, an A53:

Before: fiat32: 228605 cycles per call
After: fiat32: 188307 cycles per call
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
This commit is contained in:
Jason A. Donenfeld 2018-01-18 18:41:45 +01:00
parent d68293b8a3
commit 5306604aa5
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/keygen-html/src/curve25519_generate.c
View File

@ -232,7 +232,7 @@ static __always_inline void fe_1(fe *h)
h->v[0] = 1; h->v[0] = 1;
} }
static __always_inline void fe_add_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10]) static void fe_add_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10])
{ {
{ const uint32_t x20 = in1[9]; { const uint32_t x20 = in1[9];
{ const uint32_t x21 = in1[8]; { const uint32_t x21 = in1[8];
@ -275,7 +275,7 @@ static __always_inline void fe_add(fe_loose *h, const fe *f, const fe *g)
fe_add_impl(h->v, f->v, g->v); fe_add_impl(h->v, f->v, g->v);
} }
static __always_inline void fe_sub_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10]) static void fe_sub_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10])
{ {
{ const uint32_t x20 = in1[9]; { const uint32_t x20 = in1[9];
{ const uint32_t x21 = in1[8]; { const uint32_t x21 = in1[8];
@ -318,7 +318,7 @@ static __always_inline void fe_sub(fe_loose *h, const fe *f, const fe *g)
fe_sub_impl(h->v, f->v, g->v); fe_sub_impl(h->v, f->v, g->v);
} }
static __always_inline void fe_mul_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10]) static void fe_mul_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10])
{ {
{ const uint32_t x20 = in1[9]; { const uint32_t x20 = in1[9];
{ const uint32_t x21 = in1[8]; { const uint32_t x21 = in1[8];
@ -449,7 +449,7 @@ static __always_inline void fe_mul_tll(fe *h, const fe_loose *f, const fe_loose
fe_mul_impl(h->v, f->v, g->v); fe_mul_impl(h->v, f->v, g->v);
} }
static __always_inline void fe_sqr_impl(uint32_t out[10], const uint32_t in1[10]) static void fe_sqr_impl(uint32_t out[10], const uint32_t in1[10])
{ {
{ const uint32_t x17 = in1[9]; { const uint32_t x17 = in1[9];
{ const uint32_t x18 = in1[8]; { const uint32_t x18 = in1[8];

8
src/curve25519.c
View File

@ -957,7 +957,7 @@ static __always_inline void fe_1(fe *h)
h->v[0] = 1; h->v[0] = 1;
} }
static __always_inline void fe_add_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10]) static void fe_add_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10])
{ {
{ const uint32_t x20 = in1[9]; { const uint32_t x20 = in1[9];
{ const uint32_t x21 = in1[8]; { const uint32_t x21 = in1[8];
@ -1000,7 +1000,7 @@ static __always_inline void fe_add(fe_loose *h, const fe *f, const fe *g)
fe_add_impl(h->v, f->v, g->v); fe_add_impl(h->v, f->v, g->v);
} }
static __always_inline void fe_sub_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10]) static void fe_sub_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10])
{ {
{ const uint32_t x20 = in1[9]; { const uint32_t x20 = in1[9];
{ const uint32_t x21 = in1[8]; { const uint32_t x21 = in1[8];
@ -1043,7 +1043,7 @@ static __always_inline void fe_sub(fe_loose *h, const fe *f, const fe *g)
fe_sub_impl(h->v, f->v, g->v); fe_sub_impl(h->v, f->v, g->v);
} }
static __always_inline void fe_mul_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10]) static void fe_mul_impl(uint32_t out[10], const uint32_t in1[10], const uint32_t in2[10])
{ {
{ const uint32_t x20 = in1[9]; { const uint32_t x20 = in1[9];
{ const uint32_t x21 = in1[8]; { const uint32_t x21 = in1[8];
@ -1174,7 +1174,7 @@ static __always_inline void fe_mul_tll(fe *h, const fe_loose *f, const fe_loose
fe_mul_impl(h->v, f->v, g->v); fe_mul_impl(h->v, f->v, g->v);
} }
static __always_inline void fe_sqr_impl(uint32_t out[10], const uint32_t in1[10]) static void fe_sqr_impl(uint32_t out[10], const uint32_t in1[10])
{ {
{ const uint32_t x17 = in1[9]; { const uint32_t x17 = in1[9];
{ const uint32_t x18 = in1[8]; { const uint32_t x18 = in1[8];